Faster image scrolling and fix zoom out issue #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAicewizard
reviewed
Oct 10, 2024
Comment on lines
+177
to
+178
| // placeholder: | ||
| // 'assets/img/photo_placeholder_${(360 - photos[i].rotation) % 360}.png'), |
Comment on lines
-184
to
+189
| minScale: PhotoViewComputedScale.contained * 0.8, | ||
| minScale: PhotoViewComputedScale.contained * 1, |
There was a problem hiding this comment.
Is there a reason this was changed? I cannot test this atm, I will test next week
There was a problem hiding this comment.
With 0.8, you can zoom out the image from its default position. Not just 'pinch' it, but after that it will suddenly not take the full width up anymore, which we thought was pretty cursed. Putting it at 1 instead solves that so fully zoomed out is still the full screen width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #458
Summary
Previously, you could zoom out on a photo in an album and it would stay zoomed out.
Furthermore, photos are not cached correctly, so when you open a photo and scroll to the next one, the loading time is annoyingly long.
How to test
Steps to test the changes you made: